Skip to content

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Apr 7, 2025

Contributes to #7811

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
  • Does the change make any security assumptions or guarantees?
    • No
  • Does the change require an update in our Aspire docs?
    • No

@eerhardt eerhardt requested review from Copilot and davidfowl April 7, 2025 19:27
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/Aspire.Hosting.Azure/IAzureKeyVaultResource.cs:33

  • [nitpick] Consider updating the XML documentation for this method to reflect the new name 'GetSecret' for consistency.
IAzureKeyVaultSecretReference GetSecret(string secretName);

@github-actions github-actions bot added the area-integrations Issues pertaining to Aspire Integrations packages label Apr 7, 2025
@eerhardt eerhardt requested a review from DamianEdwards April 7, 2025 19:27
@eerhardt
Copy link
Member Author

eerhardt commented Apr 7, 2025

/backport to release/9.2

Copy link
Contributor

github-actions bot commented Apr 7, 2025

Started backporting to release/9.2: https://github.com/dotnet/aspire/actions/runs/14317780207

@eerhardt eerhardt merged commit d0140d2 into dotnet:main Apr 7, 2025
175 checks passed
@eerhardt eerhardt deleted the GetSecret branch April 7, 2025 20:23
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants