Return correct exit code from build.ps1 #8582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build.cmd failed to return an actual exit code from eng/build.ps1, which resulted in CI steps reported as "passed" despite errors during the execution.
github-actions
bot
added
the
area-engineering-systems
danmoseley
approved these changes
Apr 7, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This baffled me for some time - I kick off a GHA build, and the log shows multiple build errors, yet the step is reported as success. Which implies the exit code is lost somewhere in transit.
E.g., eng/build.ps1 exists with
1, yet build.cmd exits with0:This fixes the issue. The proof is here.