Constrain test-only dependencies to /tests folder #8576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (4)
- Directory.Packages.props: Language not supported
- src/Components/Aspire.Microsoft.Data.SqlClient/Aspire.Microsoft.Data.SqlClient.csproj: Language not supported
- tests/Aspire.Microsoft.Data.SqlClient.Tests/Aspire.Microsoft.Data.SqlClient.Tests.csproj: Language not supported
- tests/Directory.Packages.props: Language not supported
github-actions
bot
added
the
area-integrations
|
/cc: @joperezr |
RussKie
added
area-engineering-systems
danmoseley
approved these changes
Apr 7, 2025
danmoseley
reviewed
Apr 7, 2025
| <PackageVersion Include="Testcontainers.Oracle" Version="$(TestcontainersPackageVersion)" /> | ||
| <PackageVersion Include="Testcontainers.Elasticsearch" Version="$(TestcontainersPackageVersion)" /> | ||
| <PackageVersion Include="Testcontainers" Version="$(TestcontainersPackageVersion)" /> | ||
| <PackageVersion Include="GitHubActionsTestLogger" Version="2.4.1" /> | ||
| <!-- playground apps dependencies --> |
There was a problem hiding this comment.
aren't playground things test-only @RussKie ?
There was a problem hiding this comment.
No, they run out of the tests scenario too, for local runs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #8279