Improve path prompt for aspire new command. #8542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/Aspire.Cli/DotNetCliRunner.cs:26
- Ensure that appending projectFile.FullName to the msbuild arguments is intended and that projectFile is valid in all execution paths.
string[] cliArgs = ["msbuild", "-getproperty:IsAspireHost,AspireHostingSDKVersion", projectFile.FullName];
src/Aspire.Cli/Commands/NewCommand.cs:95
- Verify that using pathAppendage directly as the default output path meets the requirement for a relative path and does not inadvertently impact downstream file operations that might expect an absolute path.
defaultValue: pathAppendage ?? ".",
mitchdenny
added
area-cli
and removed
needs-area-label
davidfowl
approved these changes
Apr 4, 2025
|
/backport to release/9.2 |
|
Started backporting to release/9.2: https://github.com/dotnet/aspire/actions/runs/14257138490 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the way that we prompt for the output path in the
aspire newcommand. Previously we howed the absolution path as a default. Now we show a relative path which the user can accept or override with a new relative path or a new absolute path:aspire-new-path-fix.mp4