-
Notifications
You must be signed in to change notification settings - Fork 684
Retry resource stopping operation #8541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
tests/Aspire.Hosting.Tests/Dcp/TestKubernetesService.cs:177
- Consider safely casting patch.Content (using a safe cast or adding a null-check) to avoid potential runtime exceptions if the content is not of type Json.Patch.JsonPatch.
Json.Patch.JsonPatch jsonPatch = (Json.Patch.JsonPatch)patch.Content;
Backport too please! |
/backport to release/9.2 |
Started backporting to release/9.2: https://github.com/dotnet/aspire/actions/runs/14258144458 |
@davidfowl backporting to "release/9.2" failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Patch format detection failed.
Error: The process '/usr/bin/git' failed with exit code 128 Please backport manually! |
@karolz-ms all yours 😄 |
Honestly IMO this is not super critical to be backported to 9.2 but I will try |
Started backporting to release/9.2: https://github.com/dotnet/aspire/actions/runs/14269439222 |
Description
Applies retry logic to resource stopping operation
Fixes # (issue)
Fixes #8481
Checklist
<remarks />
and<code />
elements on your triple slash comments?breaking-change
template):doc-idea
template):I ran all
Aspire.Hosting
andAspire.Hosting.Testing
tests locally and only 2 quarantined tests failed (one passed on re-run). The changes toTestKubernetesService
are required to make tests pass.