Remove null/nullable parameter from DistributedApplicationExecutionContext

[sebastienros]

Description

1- There is an overload that doesn't take the parameter.
2- Property can't be created with a null PublisherName.

Contributes to #7811

Checklist

• Is this feature complete?
  • Yes. Ready to ship.
  • No. Follow-up changes expected.
• Are you including unit tests for the changes and scenario tests if relevant?
  • Yes
  • No
• Did you add public API?
  • Yes
    • If yes, did you have an API Review for it?
      • Yes
      • No
    • Did you add <remarks /> and <code /> elements on your triple slash comments?
      • Yes
      • No
  • No
• Does the change make any security assumptions or guarantees?
  • Yes
    • If yes, have you done a threat model and had a security review?
      • Yes
      • No
  • No
• Does the change require an update in our Aspire docs?
  • Yes
    • Is this introducing a breaking change?
      • Yes
        • Link to aspire-docs issue (please use this breaking-change template):
      • No
        • Link to aspire-docs issue (please use this doc-idea template):
  • No

[Copilot]

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/Aspire.Hosting/DistributedApplicationExecutionContextOptions.cs:24

• The removal of the default null for publisherName enforces non-null values, but there is no validation to ensure that a valid publisherName is provided when operation is set to Publish. Consider adding an argument check and throw an exception if publisherName is null or empty to prevent misconfiguration.

public DistributedApplicationExecutionContextOptions(DistributedApplicationOperation operation, string? publisherName)

src/Aspire.Hosting/DistributedApplicationExecutionContext.cs:39

• Changing PublisherName to non-nullable requires ensuring that it is always initialized properly. Verify that all code paths assign a valid non-null value to PublisherName to avoid potential runtime exceptions.

public string PublisherName { get; set; }

[sebastienros]

@mitchdenny This one was not sure but since there is no way to pass a null values from the ctors. Unless we expect someone to set the value afterwards.

[mitchdenny]

If you don't pass a publisher name then it is null - which is valid if you are not in publisher mode.

[sebastienros]

public DistributedApplicationExecutionContext(DistributedApplicationOperation operation) : this(operation, "manifest")

won't be null, right?

[mitchdenny]

Looks good, just make PublisherName nullable again.

[sebastienros]

/backport to release/9.2

[github-actions]

Started backporting to release/9.2: https://github.com/dotnet/aspire/actions/runs/14254488342