Rename test env controlling and project test capabilities variables

[RussKie]

No description provided.

[Copilot]

Pull Request Overview

This PR revises the documentation in tests/README.md to reflect updates in variable naming for controlling test environments and project test capabilities. Key changes include updating text for clarity and consistency with renamed MSBuild properties, along with minor formatting and capitalization improvements.

• Updated CI and Helix instructions to match variable renaming
• Improved capitalization and consistency in documentation

Files not reviewed (13)

• eng/Testing.props: Language not supported
• eng/Testing.targets: Language not supported
• tests/Aspire.Cli.Tests/Aspire.Cli.Tests.csproj: Language not supported
• tests/Aspire.Dashboard.Tests/Aspire.Dashboard.Tests.csproj: Language not supported
• tests/Aspire.Elastic.Clients.Elasticsearch.Tests/Aspire.Elastic.Clients.Elasticsearch.Tests.csproj: Language not supported
• tests/Aspire.EndToEnd.Tests/Aspire.EndToEnd.Tests.csproj: Language not supported
• tests/Aspire.Hosting.Docker.Tests/Aspire.Hosting.Docker.Tests.csproj: Language not supported
• tests/Aspire.Hosting.Testing.Tests/Aspire.Hosting.Testing.Tests.csproj: Language not supported
• tests/Aspire.Hosting.Tests/Aspire.Hosting.Tests.csproj: Language not supported
• tests/Aspire.Oracle.EntityFrameworkCore.Tests/Aspire.Oracle.EntityFrameworkCore.Tests.csproj: Language not supported
• tests/Aspire.Playground.Tests/Aspire.Playground.Tests.csproj: Language not supported
• tests/Directory.Build.targets: Language not supported
• tests/Shared/RepoTesting/Aspire.RepoTesting.targets: Language not supported

[radical]

We should also run a Azdo build to check that nothing breaks.

[radical]

Looks good. Added some comments. Is the azdo build for this looking good too?

[RussKie]

Is the azdo build for this looking good too?

Yes, both a PR and a full manual build

[radical]

Waiting on an outerloop tests run for this - https://github.com/dotnet/aspire/actions/runs/14324978740/job/40148735516

[radical]

LGTM! Thank you for working on this, and patience with the review process!

Feel free to merge once the latest azdo run is green with the same test count :)

[Youssef1313]

Is this logic correct?
Shouldn't RunOnGithubActionsWindows be considered only when on Windows, and RunOnGithubActionsLinux be considered only on Linux, instead of ORing them together without any OS checks?

Currently, it seems like Playground is run on GitHub Actions on Windows (VSTest just ignores when no tests are run, but with my PR for MTP I'm getting zero tests ran for Playground)

Could you please double check @RussKie? Am I missing something here?

[RussKie]

Yes, the logic is correct.
These variables denote the "capabilities":

aspire/eng/Testing.targets

Lines 13 to 22 in ac098f7

	Project requirements:
	- RunOnGithubActions: indicates whether tests should run on GitHub Actions (either Windows or Linux); computed.
	- RunOnGithubActionsWindows: indicates whether tests should run on Windows in GitHub Actions; default is true; overridable.
	- RunOnGithubActionsLinux: indicates whether tests should run on Linux in GitHub Actions; default is true; overridable.
	- RunOnAzdoCI: indicates whether tests should run on Azure DevOps (either Windows or Linux); always false, if RunOnAzdoHelix=true; computed.
	- RunOnAzdoCIWindows: indicates whether tests should run on Windows in Azure DevOps; default is true; overridable.
	- RunOnAzdoCILinux: indicates whether tests should run on Linux in Azure DevOps; default is true; overridable.
	- RunOnAzdoHelix: indicates whether tests should run on Helix (either Windows or Linux); computed.
	- RunOnAzdoHelixWindows: indicates whether tests should run on Windows in Helix; default is true; overridable.
	- RunOnAzdoHelixLinux: indicates whether tests should run on Linux in Helix; default is true; overridable.

...and used to generate runsheets, which then executed on individual build agents.

You can see how it is being used in https://github.com/dotnet/aspire/pull/8618/files#diff-ce47bb41900ee3082587fce1184e86392a2c25a05882281792f04e8e8abc51f4.

[RussKie]

After a third look and two cups of tea later, I see the issue now. Thank you for pointing it out.
SkipTests should be OS-aware, so that we don't run a test on Windows, if the test project declared it couldn't be run on Windows. This is getting fixed in #8687.