Skip to content

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Feb 14, 2025

Description

Fix regression from #7549 (oops) where the tree doesn't update in mobile view.

Also, I noticed the indent in the mobile view for the metrics page didn't match the new indent of the header.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@JamesNK
Copy link
Member Author

JamesNK commented Feb 14, 2025

/backport to release/9.1

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • src/Aspire.Dashboard/Components/Pages/Metrics.razor.css: Language not supported

Copy link
Contributor

Started backporting to release/9.1: https://github.com/dotnet/aspire/actions/runs/13322202360

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danmoseley
Copy link
Member

@adamint could you please review this and the port PR today

@adamint adamint merged commit a838286 into main Feb 14, 2025
70 checks passed
@adamint adamint deleted the jamesnk/metrics-page-resources-mobile branch February 14, 2025 21:22
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants