[release/9.4] Fix grid scrolling bugs #10861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dotnet-policy-service
bot
added
Re-opened Github-Action PR
and removed
Closed Github-Action PR
labels
JamesNK
changed the title
|
Low Risk + regression. Approved for 9.4.1 |
davidfowl
approved these changes
Aug 7, 2025
JamesNK
approved these changes
Aug 7, 2025
WeihanLi
pushed a commit
to WeihanLi/aspire
that referenced
this pull request
Aug 13, 2025
* Fix continious scroll to prevent jumping to the top * Overscan counts * Update * Update * Continious scroll is re-enabled when there is no scrollbar * Remove page logging --------- Co-authored-by: James Newton-King <[email protected]>
This was referenced Aug 29, 2025
Bump Aspire.Npgsql.EntityFrameworkCore.PostgreSQL from 9.4.0 to 9.4.1
L-U-M-E-N/Lumen.Modules.GRDF#2
Open
Open
Closed
This was referenced Sep 2, 2025
Closed
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #10740 to release/9.4
/cc @JamesNK
Customer Impact
Fixes #10841
There are a couple of issues in large grid scrolling:
The dashboard's default grid behavior is scrolling to the bottom when new content arrives. Automatically scrolling to the bottom is disabled if you've scrolled up and are no longer at the bottom of the grid. This matches what OS consoles do as content is written to them. However, sometimes this behavior breaks, and the grid stops scrolling down.
The problem is new content arriving and the grid scrolling both trigger the
onscrollevent. Races can cause the existing calculation to break:The fix is to skip calculation when new data is added to the grid. We can tell new data has been added because the total scroll height of the grid changes.
There is bad scrolling behavior with the mouse wheel in large grids of data. This is a regression introduced by FluentUI changing how data grids are rendered.
The problem occurs with virtualized grids, large amount of data, and using the scroll wheel. Scrolling will jump around erratically. It's unusable.
The fix in this PR is to increase the virtualize overscan amount (how much extra data is rendered that is out-of-site). There is a small perf hit because the client is doing extra work to render rows that aren't visible, but we're only adding up to 200 extra rows, so the impact is small. Note that this significantly improves the user experience most of the time, but it isn't a perfect fix. If you scroll aggressively then it will still jump around. But further improvements will require larger changes and have to wait for 9.5.
Testing
Manual. Can't automate this client-side behavior.
Risk
Low
Regression?
Yes. (I'm not sure what version it regressed in. 9.3?)