Tests run locally, but fail in azure pipeline

[davyvanlaere]

We have an aspire setup with quite a few dependencies, and runs fine locally, also the integration test run fine locally ( using DistributedApplicationTestingBuilder ), but the tests fail in an azure pipeline. If i look at the pipeline, i think it fails with a null reference exception even before the actual project setup is called: the exception seems to be triggered during the BeforeStartAsync() method.

   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)
--- End of stack trace from previous location ---
   at Aspire.Hosting.Testing.DistributedApplicationFactory.StartAsync(CancellationToken cancellationToken) in /_/src/Aspire.Hosting.Testing/DistributedApplicationFactory.cs:line 74
   at Aspire.Hosting.Testing.DistributedApplicationTestingBuilder.SuspendingDistributedApplicationFactory.DelegatedHost.StartAsync(CancellationToken cancellationToken) in /_/src/Aspire.Hosting.Testing/DistributedApplicationTestingBuilder.cs:line 304
   at Aspire.Hosting.Testing.DistributedApplicationTestingBuilder.SuspendingDistributedApplicationFactory.DelegatedDistributedApplication.StartAsync(CancellationToken cancellationToken) in /_/src/Aspire.Hosting.Testing/DistributedApplicationTestingBuilder.cs:line 279
   at OurProjectName.Aspire.Tests.AppHost.StartAppHost() in /home/vsts/work/1/s/src/api/tests/OurProjectName.Aspire.Tests/AppHost.cs:line 61
   at OurProjectName.Aspire.Tests.AppHost.Start() in /home/vsts/work/1/s/src/api/tests/OurProjectName.Aspire.Tests/AppHost.cs:line 49
   at OurProjectName.Aspire.Tests.AppHostInitializer.InitializeAsync() in /home/vsts/work/1/s/src/api/tests/OurProjectName.Aspire.Tests/AppHostInitializer.cs:line 12
----- Inner Stack Trace -----
   at Aspire.Hosting.Azure.AzureResourcePreparer.ProcessAzureReferences(HashSet`1 azureReferences, Object value) in /_/src/Aspire.Hosting.Azure/AzureResourcePreparer.cs:line 463
   at Aspire.Hosting.Azure.AzureResourcePreparer.GetAzureReferences(IResource resource, CancellationToken cancellationToken) in /_/src/Aspire.Hosting.Azure/AzureResourcePreparer.cs:line 377
   at Aspire.Hosting.Azure.AzureResourcePreparer.BuildRoleAssignmentAnnotations(DistributedApplicationModel appModel, List`1 azureResources, AzureProvisioningOptions options, CancellationToken cancellationToken) in /_/src/Aspire.Hosting.Azure/AzureResourcePreparer.cs:line 142
   at Aspire.Hosting.Azure.AzureResourcePreparer.BeforeStartAsync(DistributedApplicationModel appModel, CancellationToken cancellationToken) in /_/src/Aspire.Hosting.Azure/AzureResourcePreparer.cs:line 39
   at Aspire.Hosting.DistributedApplication.ExecuteBeforeStartHooksAsync(CancellationToken cancellationToken) in /_/src/Aspire.Hosting/DistributedApplication.cs:line 475
   at Aspire.Hosting.DistributedApplication.RunAsync(CancellationToken cancellationToken) in /_/src/Aspire.Hosting/DistributedApplication.cs:line 425

I tried looking in the code on github, but line 463 in AzureResourcePreparer just point to a line where an InvalidOperationException is thrown. The incoming value parameter on which they call GetType() COULD be null i guess ....

[davidfowl]

If you can provide a minimal repro then we can investigate

[davyvanlaere]

I understand, but that would take some time. Apparently a NULL value in the environment parameters could cause this.

[davidfowl]

I understand that it will take time but without more information this isn't really actionable.

While you are trying to figure out a repro, can you share the apphost?

[davyvanlaere]

I fully understand, but i found the issue. Somewhere in the apphost setup, i am explicitly setting an environment variable. Locally this had a value, but in the azure pipeline this value was null. I might be a good idea to catch this case to prevent the nullref exception (and it would be convenient to know which environment parameter is null)

So this is where null was passed:

aspire/src/Aspire.Hosting.Azure/AzureResourcePreparer.cs

Line 377 in cfb79b0

ProcessAzureReferences(azureReferences, kv.Value);

[davidfowl]

Excellent!

[davidfowl]

See #11136