Move into Shared SqlDependencyListener.cs#1308
Conversation
…d update reference in the csprojs, fix compiler error for netfx in SqlDependency.cs
…IDE1006, and IDE0059
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlDependencyListener.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlDependencyListener.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Johnny Pham <v-jopha@microsoft.com>
|
Some events were using |
I noticed that too. I'm not sure if we need to unify those and if so which one should we be using. |
|
@lcheunglci can you address the conflict please? |
After a discussion with @cheenamalhotra and @JRahnama , I believe the consensus is to use the one from netfx. I'll make the updates in the next commit. |
|
NIT: @lcheunglci There are 'new' expression simplification info suggestions for line 87,1636,1713. |
cheenamalhotra
left a comment
There was a problem hiding this comment.
Please reset branch to contain only PR related changes.
442930f to
a21542f
Compare
Relates to #1261 . Merged netfx to netcore and move it to shared src. While cleaning up the coding style errorlist, I left 2 IDE0063 (Line 957 and Line 1076) info messages because I chose to keep the scope bodied using statement and there was a IDE0079 suggesting that I remove the suppression of
CA2100:ReviewSqlQueriesForSecurityVulnerabilitieson Line 968, which I left. I may need to merge PR #1299 because there's a small change to the property to the property to retrieve the static instance ofSingletonProcessDispatcher.