Skip to content

[build] Add windows-11-arm and ubuntu-24.04-arm to CI run-tests.yaml #2760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

nietras
Copy link
Contributor

@nietras nietras commented Jun 8, 2025

@timcassell
Copy link
Collaborator

SingleBenchmarkCanBeExecutedForMultipleRuntimes is failing because it's testing Platform.X64. I think simply removing the platform from the job should work.

BenchmarkCanAllocateMoreThan2Gb test is failing because it's testing Platform.X64 and Platform.X86. It needs to be updated for Arm.

NoHangs test is also failing, though I can't tell why from the logs.

@nietras nietras changed the title [build] Add windows-11-arm to CI run-tests.yaml [build] Add windows-11-arm and ubuntu-24.04-arm to CI run-tests.yaml Jun 9, 2025
@nietras
Copy link
Contributor Author

nietras commented Jun 9, 2025

@timcassell tried to address issues in the two tests. As I have no insight into the specifics of these I am somewhat guessing here, so it is probably more a more efficient use of time if you guys just fix these directly yourselves, so feel free to make changes here or elsewhere necessary for these CI changes. Or let me know what to do specifically. :)

@timcassell
Copy link
Collaborator

I don't have a Windows Arm machine to test with, so I can only go off of the logs.

@timcassell
Copy link
Collaborator

timcassell commented Jun 9, 2025

BenchmarkCanAllocateMoreThan2Gb is failing at line 47 because ClrRuntime is not included on Arm. net481 supports Arm, so it should be tested, though I'm not sure if it should be testing Arm64 or Arm. [Edit] Looks like it only officially supports Arm64.

@timcassell
Copy link
Collaborator

If you have an Arm machine to test with, can you try to figure out why NoHangs is failing?

@filzrev
Copy link
Contributor

filzrev commented Jun 9, 2025

It seems egor-tensin/setup-clang action explicitly install x64 version Clang & LLVM

Is this settings ares used inside integration tests?
or already skipped on ARM64 platform, or testing x64 binary on ARM64?

@nietras
Copy link
Contributor Author

nietras commented Jun 10, 2025

I don't have a Windows Arm machine to test with, so I can only go off of the logs.
If you have an Arm machine to test with, can you try to figure out why NoHangs is failing?

I don't have any ARM pc. Hence, why I am in no better shape to fix these issues, worse even since have no idea why these tests look like they do. 😅 So if anybody has an idea how to fix please do, or make a pr to this pr with necessary changes.

Ignore NoHangs test on full Framework on non-x86.
@timcassell
Copy link
Collaborator

timcassell commented Jun 14, 2025

I pushed some test fixes, but I'm not sure how to fix remaining.

Disassembler fails on test-windows-core (windows-11-arm)

Failed CanDisassembleAllMethodCalls [1 ms]
  Error Message:
   System.InvalidOperationException : No data found for BenchmarkDotNet.IntegrationTests.DisassemblyDiagnoserTests.CanDisassembleAllMethodCalls

New Mono tests are all failing

error NU1101: Unable to find package Microsoft.NETCore.App.Runtime.Mono.win-arm64. No packages exist with this id in source(s): api.nuget.org, dotnet10, dotnet6, dotnet7, dotnet8, dotnet9 

@adamsitnik Maybe you have ideas, or could ping someone who might?

@timcassell

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants