Skip to content

Including Distributed Postgres Cache information #35889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 9, 2025

Conversation

JaredMSFT
Copy link
Contributor

@JaredMSFT JaredMSFT commented Aug 5, 2025

@JaredMSFT JaredMSFT requested a review from tdykstra as a code owner August 5, 2025 14:30
@JaredMSFT
Copy link
Contributor Author

@dotnet-policy-service agree company="Microsoft"

Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great; I just noticed a couple mentions of passwords and they need something said about secure handling of credentials. See the article I linked to in the comments below.

@tdykstra tdykstra self-requested a review August 8, 2025 02:18
@wadepickett wadepickett self-requested a review August 8, 2025 02:40
@wadepickett
Copy link
Contributor

@tdykstra, adding myself as a backup reviewer per your request.

Copy link
Contributor

@wadepickett wadepickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JaredMSFT, this looks great!!. I only see a very minor item to consider:
Should "Postgres" should be "PostgreSQL" to avoid using two different names for the same thing? If so I can change that for you and publish, otherwise I will publish as is.

Sql Server > SQL Server typo fix.
@JaredMSFT JaredMSFT closed this Aug 9, 2025
@JaredMSFT JaredMSFT reopened this Aug 9, 2025
@wadepickett wadepickett merged commit 936addf into dotnet:main Aug 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants