-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Including Distributed Postgres Cache information #35889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
adding Postgres cache
@dotnet-policy-service agree company="Microsoft" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great; I just noticed a couple mentions of passwords and they need something said about secure handling of credentials. See the article I linked to in the comments below.
aspnetcore/performance/caching/distributed/includes/distributed5.md
Outdated
Show resolved
Hide resolved
@tdykstra, adding myself as a backup reviewer per your request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JaredMSFT, this looks great!!. I only see a very minor item to consider:
Should "Postgres" should be "PostgreSQL" to avoid using two different names for the same thing? If so I can change that for you and publish, otherwise I will publish as is.
Sql Server > SQL Server typo fix.
We've recently released the Microsoft.Extensions.Caching.Postgres library and wanted to include this option in our docs.
Internal previews