-
-
Notifications
You must be signed in to change notification settings - Fork 5
Add Typescript support #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Charlike Mike Reagent <[email protected]>
Signed-off-by: Charlike Mike Reagent <[email protected]>
Signed-off-by: Charlike Mike Reagent <[email protected]>
Signed-off-by: Charlike Mike Reagent <[email protected]>
Signed-off-by: Charlike Mike Reagent <[email protected]>
Signed-off-by: Charlike Mike Reagent <[email protected]>
Signed-off-by: Charlike Mike Reagent <[email protected]>
Signed-off-by: Charlike Mike Reagent <[email protected]>
Signed-off-by: Charlike Mike Reagent <[email protected]>
Signed-off-by: Charlike Mike Reagent <[email protected]>
Signed-off-by: Charlike Mike Reagent <[email protected]>
Signed-off-by: Charlike Mike Reagent <[email protected]>
Signed-off-by: Charlike Mike Reagent <[email protected]>
Signed-off-by: Charlike Mike Reagent <[email protected]>
Signed-off-by: Charlike Mike Reagent <[email protected]>
Signed-off-by: Charlike Mike Reagent <[email protected]>
Signed-off-by: Charlike Mike Reagent <[email protected]>
Signed-off-by: Charlike Mike Reagent <[email protected]>
Oooh yea, it really was excellent... Thanks for reminding me about that. Seems like I didn't port the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@doowb @jonschlinkert heya, what's the state of the refactors and updates? Jon isn't very active last year... |
Hey, FWIW, I know you're not looking for a long explanation, but we've known each other a while and I thought you might like to know why we haven't seemed as active lately:
So, to be clear, we still love programming, we still love open source, and we're still spending the same amount of time developing open source tools, but we're spending less time putting small fires out and discussing details on GitHub. I know that doesn't help your situation, but still, I thought you might want to know. |
Oh, I'm looking exactly for that, haha. You know I love the long read and writes. Yea. It's exactly what I wanted to hear and I thought that that's what's happening. And we know I feel you. I'm not active that much anymore too. Open source is really fricking depressing thing, and a ton of people can't realize and even imagine how hard that "job" is. It's crazy. Recently I discussed with one of my real-life best friends for years, and other peers through the years, the thing about Open Source and Free software, and they can't even comprehend and imagine the whole thing. How it can be super sad, but at the same time, a very powerful thing. The whole work through the years is legendary, and the Node ecosystem is living and breathing every single day because of that exceptional amount of work. It's very empowering. But yea, the community deserves your more private way, discussions, and privacy, exactly because of those bad events that happened multiple times. And I've seen them too. I'm probably one of the few on your side. I'm planning something big too and I'm reconsidering my approach too. So... fair enough. I'm always open for you and your things and discussions, even in private.
I just wanted to ensure what's happening and to see if we can proceed and merge some small things, because they are good. |
Exactly what I was looking for! |
@ilanl just "wrap" them and passed them to handlebars. something like const asyncAddHelper = asyncHelpers.wrapHelper('add', async (a, b) => a + b);
const asyncDivideHelper = asyncHelpers.wrapHelper('divide', async (a, b) => a / b);
// pass them to hbs ( don't remember if that was the hbs method)
hbs.registerHelpers({ asyncAddHelper, asyncDivideHelper }); or you can just pass an object to .wrapHelper (if you're using this refactor branch) asyncHelpers.wrapHelper({
foo: () => {},
async bar() {}
}) |
Continuing on @tunnckoCore's excellent refactor, this additionally adds typescript support.