Conversation
gagbo
suggested changes
Aug 31, 2023
Member
gagbo
left a comment
There was a problem hiding this comment.
Hello,
Still not sure when it's going to get merged, but there are a few things you can change meanwhile to help the PR :)
Contributor
|
Is anything else needed for this PR to merge into the master? I am here to help. |
Co-authored-by: Prashant Vithani <prashantvithani@gmail.com>
|
Anything left for the theme to be merged? |
Author
|
I'd include rebelot's here and name differently the custom variations. Wave, Lotus and Dragon would be the originals and the other variations would be up to you. |
Author
|
Sounds good. All the necessary changes have been made. Let me know if there are any issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




This theme is based on rebelot's theme by the same name. I've never written a theme before and still pretty new to using emacs so please let me know if I've missed something/something doesn't look right.
Fixes #0000
References #0000
Replaces #0000
Screenshots