Skip to content

Emit no notices on PHP 7.4 #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

Piskvor
Copy link

@Piskvor Piskvor commented Jan 16, 2020

fread() and fwrite() may emit E_NOTICE as seen in https://bugs.php.net/bug.php?id=78482
This is apparently by-design, but the resulting ErrorException propagates all the way up the stack, crashing the application.
Building on #76 , silence this notice - as the condition is still indicated by the return value, there's no point in emitting it.

@Piskvor Piskvor marked this pull request as ready for review January 16, 2020 16:07
@bsweeney bsweeney added this to the 0.5.2 milestone Jan 31, 2020
@bsweeney bsweeney linked an issue Jun 27, 2020 that may be closed by this pull request
@bsweeney
Copy link
Member

See comments on #78.

@bsweeney bsweeney closed this Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 7.4 E_NOTICE on read error
3 participants