Emit no notices on PHP 7.4 #77
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fread() and fwrite() may emit E_NOTICE as seen in https://bugs.php.net/bug.php?id=78482
This is apparently by-design, but the resulting ErrorException propagates all the way up the stack, crashing the application.
Building on #76 , silence this notice - as the condition is still indicated by the return value, there's no point in emitting it.