Fix an issue with INSERT IGNORE on auto-increment primary key tables #1166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related discussion is #1161. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When executing SQL equivalent to INSERT IGNORE on a table with an auto-increment primary key, an error occurred due to the inability to retrieve the auto-incremented value. This pull request fixes that error.
Additionally, adjustments have been made to align the behavior across multiple DBMS dialects when the auto-increment primary key is implicitly used as a key for duplicate checks.
In particular, when using H2 Database, Oracle Database, or SQL Server, it is recommended to explicitly specify the key used for duplicate checks. In this pull request, the Criteria API's
Entityqlhas been updated to allow specifying the key as well.