Skip to content

Rewrote transaction tests to be much more succinct, and added several more #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 27, 2021
Merged

Rewrote transaction tests to be much more succinct, and added several more #434

merged 9 commits into from
May 27, 2021

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented May 26, 2021

No description provided.

@zachmu zachmu requested a review from Hydrocharged May 26, 2021 23:24
Hydrocharged
Hydrocharged approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Having a table a with pk b and then clients a and b gets a little hard to read, but it's no biggie lol

@zachmu
Copy link
Member Author

zachmu commented May 27, 2021

LGTM! Having a table a with pk b and then clients a and b gets a little hard to read, but it's no biggie lol

Yeah that's actually a pretty good point, I'll fix this in a followup

@zachmu zachmu merged commit 8d9a7ba into master May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hydrocharged Hydrocharged Hydrocharged approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zachmu @Hydrocharged