[WIP]: LastIncrementId and name resolution collision fix #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-wm-arthur
force-pushed
the
andy/last-increment-id
branch
from
dc1964a to
1806284
Compare
andy-wm-arthur
force-pushed
the
andy/last-increment-id
branch
from
587aae7 to
d23871f
Compare
zachmu
reviewed
May 17, 2021
| @@ -55,7 +58,7 @@ func pushdownSort(ctx *sql.Context, a *Analyzer, n sql.Node, scope *Scope) (sql. | |||
| name := strings.ToLower(n.Name()) | |||
| if stringContains(childAliases, name) { | |||
| colsFromChild = append(colsFromChild, n.Name()) | |||
| } else if !stringContains(schemaCols, name) { | |||
| } else if !tableColsContains(schemaCols, tableColFromNameable(n)) { | |||
There was a problem hiding this comment.
Seems obv correct, but make sure you add a test that breaks before and works now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.