Skip to content

Added IS NULL and IS NOT NULL to indexing #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 3, 2020
Merged

Added IS NULL and IS NOT NULL to indexing #237

merged 2 commits into from
Dec 3, 2020

Conversation

Hydrocharged
Copy link
Contributor

No description provided.

@Hydrocharged Hydrocharged requested a review from zachmu December 2, 2020 12:57
zachmu
zachmu approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG except for some code you left lying around after a return stmt

zachmu
zachmu reviewed Dec 2, 2020
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also verify that there are engine tests of this behavior. Probably need to add a couple.

@Hydrocharged Hydrocharged merged commit a492298 into master Dec 3, 2020
@Hydrocharged Hydrocharged deleted the daylon/is-null branch December 3, 2020 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hydrocharged @zachmu