Add row length guards #2342
Merged
Add row length guards #2342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicktobey
approved these changes
Feb 23, 2024
sql/types/size.go
Outdated
| import "github.com/dolthub/go-mysql-server/sql" | ||
|
|
||
| // SchemaAvgLength returns the expected storage length assuming | ||
| // blobs and text will be ref'd out of band. |
There was a problem hiding this comment.
If blobs are always out of band, then this comment is misleading.
There was a problem hiding this comment.
it's leaking a storage layer into the engine that won't be true for all integrators. alternatively I could have integrators do their own execution time checks, during CreateTable, AlterTable, ... etc
There was a problem hiding this comment.
actually I might like that better, there's a ValidateForInsert(schema) on the Dolt side that might be a more natural place to do this check. will update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests and basic engine-side guards similar to mysql's behavior.
re: dolthub/dolt#7524