Allow primary keys with auto_increment columns to be dropped when an appropriate index exists
#2316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…appropriate supporting index exists.
…ckage so that integrators can leverage it
…ues still work after dropping the PK
This was referenced Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL allows a primary key with an
auto_incrementcolumn to be dropped as long as there is a secondary index that includes theauto_incrementcolumn as the first column in the index. (MySQL Reference)This PR also enables dropping a primary key by referencing it by it's ID (
PRIMARY), in order to match MySQL's behavior, e.g.Related to dolthub/dolt#7456