Skip to content

Zachmu/inserts #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 12, 2020
Merged

Zachmu/inserts #206

merged 6 commits into from
Oct 12, 2020

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Oct 9, 2020

More trigger tests, and support for more kinds of SELECT statements as part of an INSERT

@zachmu zachmu requested a review from Hydrocharged October 9, 2020 19:10
@zachmu
Merge master
d9be614 
Signed-off-by: Zach Musgrave <[email protected]>
Hydrocharged
Hydrocharged reviewed Oct 12, 2020
View reviewed changes
Copy link
Contributor

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but try that query on your local copy of MySQL. The error doesn't seem right...

@zachmu
PR feedback
60ffca4 
Signed-off-by: Zach Musgrave <[email protected]>
@zachmu zachmu merged commit 322369a into master Oct 12, 2020
@Hydrocharged Hydrocharged deleted the zachmu/inserts branch October 16, 2020 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hydrocharged Hydrocharged Hydrocharged left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zachmu @Hydrocharged