Skip to content

Implemented drop trigger #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2020
Merged

Implemented drop trigger #205

merged 1 commit into from
Oct 9, 2020

Conversation

Hydrocharged
Copy link
Contributor

@Hydrocharged Hydrocharged commented Oct 8, 2020 •
edited
Loading

As discussed, we disallow dropping any triggers that are referenced in other triggers.

@Hydrocharged Hydrocharged requested a review from zachmu October 8, 2020 10:32
zachmu
zachmu approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, just a couple comments (and address the DDL struct comment from the other PR)

@Hydrocharged Hydrocharged force-pushed the daylon/delete-triggers branch from 9316e56 to 2fd9d52 Compare October 9, 2020 08:19
@Hydrocharged Hydrocharged merged commit 4114db6 into master Oct 9, 2020
@Hydrocharged Hydrocharged deleted the daylon/delete-triggers branch October 9, 2020 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hydrocharged @zachmu