Db/fix collations #186
Merged
Db/fix collations #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coffeegoddd
requested review from
zachmu and
Hydrocharged
and removed request for
zachmu
coffeegoddd
commented
Sep 4, 2020
Comment on lines
+1310
to
+1314
| s, ok := CollationToMySQLVals[c] | ||
| if !ok { | ||
| return Y | ||
| } | ||
| return s.IsDefault |
There was a problem hiding this comment.
should this be
if c == Collation_Default {
return Y
}
return N
instead?
coffeegoddd
force-pushed
the
db/fix-collations
branch
from
97c6e10 to
c052c03
Compare
zachmu
reviewed
Sep 4, 2020
enginetest/queries.go
Outdated
| }, | ||
| { | ||
| sql.Collation_utf8_general_ci.String(), | ||
| "utf8mb3", |
There was a problem hiding this comment.
Darn it Zach, utf8mb3 and utf8 are aliases. utf8 is deprecated so we're explicit in using utf8mb3 if you pass in utf8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.