Fix prep AS OF #1054
Merged
Fix prep AS OF #1054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmu
reviewed
Jun 10, 2022
| to, err = resolveTable(ctx, plan.NewUnresolvedTable(n.Name(), db), a) | ||
| var asof sql.Expression | ||
| if n.AsOf != nil { | ||
| asof = expression.NewLiteral(n.AsOf, nil) |
There was a problem hiding this comment.
Why is this conversion step necessary? Why not just resolveTable(plan.NewUnresolvedTableAsOf(n.name, db, n.AsOf)?
zachmu
reviewed
Jun 10, 2022
| to, err = resolveTable(ctx, plan.NewUnresolvedTable(n.Name(), db), a) | ||
| var asof sql.Expression | ||
| if n.AsOf != nil { | ||
| asof = expression.NewLiteral(n.AsOf, nil) |
There was a problem hiding this comment.
Why is this conversion step necessary? Why not just resolveTable(plan.NewUnresolvedTableAsOf(n.name, db, n.AsOf)?
There was a problem hiding this comment.
The constructor expected an sql.Expression argument
There was a problem hiding this comment.
I could do more work to clean up asof handling/do a type inference if you want
zachmu
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepared AS OFs errored when the asof target was not a bindvar. All of our previous tests treated ASOF also as a bindvar.
companion PR: dolthub/dolt#3592