Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions enginetest/enginetests.go
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,17 @@ func TestQueriesPrepared(t *testing.T, harness Harness) {
}
}

func TestPreparedStaticIndexQuery(t *testing.T, harness Harness) {
engine := NewEngine(t, harness)
ctx := NewContextWithEngine(harness, engine)

RunQueryWithContext(t, engine, ctx, "CREATE TABLE squares (i bigint primary key, square bigint);")
engine.PrepareQuery(ctx, "select * from squares where i = 1")
RunQueryWithContext(t, engine, ctx, "INSERT INTO squares VALUES (0, 0), (1, 1), (2, 4), (3, 9);")
TestQueryWithContext(t, ctx, engine, "select * from squares where i = 1",
[]sql.Row{{1, 1}}, sql.Schema{{Name: "i", Type: sql.Int64}, {Name: "square", Type: sql.Int64}}, nil)
}

// Runs the query tests given after setting up the engine. Useful for testing out a smaller subset of queries during
// debugging.
func RunQueryTests(t *testing.T, harness Harness, queries []QueryTest) {
Expand Down
4 changes: 4 additions & 0 deletions enginetest/memory_engine_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,10 @@ func TestSpatialQueriesSimple(t *testing.T) {
enginetest.TestSpatialQueries(t, enginetest.NewMemoryHarness("simple", 1, testNumPartitions, true, nil))
}

func TestPreparedStaticIndexQuerySimple(t *testing.T) {
enginetest.TestPreparedStaticIndexQuery(t, enginetest.NewMemoryHarness("simple", 1, testNumPartitions, true, nil))
}

// TestQueriesSimple runs the canonical test queries against a single threaded index enabled harness.
func TestQueriesSimple(t *testing.T) {
enginetest.TestQueries(t, enginetest.NewMemoryHarness("simple", 1, testNumPartitions, true, nil))
Expand Down
2 changes: 1 addition & 1 deletion sql/analyzer/resolve_columns.go
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ func getNodeAvailableNames(n sql.Node, scope *Scope) availableNames {
for i, n := range append(append(([]sql.Node)(nil), n), scope.InnerToOuter()...) {
transform.Inspect(n, func(n sql.Node) bool {
switch n := n.(type) {
case *plan.SubqueryAlias, *plan.ResolvedTable, *plan.ValueDerivedTable, *plan.RecursiveTable, *plan.RecursiveCte, *information_schema.ColumnsTable:
case *plan.SubqueryAlias, *plan.ResolvedTable, *plan.ValueDerivedTable, *plan.RecursiveTable, *plan.RecursiveCte, *information_schema.ColumnsTable, *plan.IndexedTableAccess:
name := strings.ToLower(n.(sql.Nameable).Name())
names.indexTable(name, name, i)
return false
Expand Down
23 changes: 18 additions & 5 deletions sql/analyzer/resolve_tables.go
Original file line number Diff line number Diff line change
Expand Up @@ -269,29 +269,42 @@ func reresolveTables(ctx *sql.Context, a *Analyzer, node sql.Node, scope *Scope,
db = n.Database.Name()
}
to, err = resolveTable(ctx, plan.NewUnresolvedTable(n.Name(), db), a)
if err != nil {
return nil, transform.SameTree, err
}
new := transferProjections(from, to.(*plan.ResolvedTable))
return new, transform.NewTree, nil
case *plan.IndexedTableAccess:
from = n.ResolvedTable
if n.Database() != nil {
db = n.Database().Name()
}
to, err = resolveTable(ctx, plan.NewUnresolvedTable(n.ResolvedTable.Name(), db), a)
if err != nil {
return nil, transform.SameTree, err
}
new := *n
new.ResolvedTable = transferProjections(from, to.(*plan.ResolvedTable))
return &new, transform.NewTree, nil
case *plan.DeferredAsOfTable:
from = n.ResolvedTable
to, err = resolveTable(ctx, plan.NewDeferredAsOfTable(n.ResolvedTable, n.AsOf()), a)
if err != nil {
return nil, transform.SameTree, err
}
new := transferProjections(from, to.(*plan.ResolvedTable))
return new, transform.NewTree, nil
default:
return n, transform.SameTree, nil
}
if err != nil {
return nil, transform.SameTree, err
}

new := transferProjections(from, to.(*plan.ResolvedTable))
return new, transform.NewTree, nil
return n, transform.SameTree, nil
})
}

// transferProjections moves projections from one table scan to another
func transferProjections(from, to *plan.ResolvedTable) sql.Node {
func transferProjections(from, to *plan.ResolvedTable) *plan.ResolvedTable {
var fromTable sql.Table
switch t := from.Table.(type) {
case sql.TableWrapper:
Expand Down
1 change: 0 additions & 1 deletion sql/plan/indexed_table_access.go
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,6 @@ func (i IndexedTableAccess) WithTable(table sql.Table) (*IndexedTableAccess, err
if err != nil {
return nil, err
}

i.ResolvedTable = nrt
return &i, nil
}
Expand Down