Incorrect access modifier for SymbolConstructor.observable

[jason0x43]

Bug

SymbolConstrutor.observable has the default access modifier in @dojo/shim, but should be readonly. Currently it conflicts with recent node typings, which specifically flag observable as readonly.

Previous versions of the Node typings (< 10, 10.x before May) didn't include the observable property on SymbolConstructor, so fixing this shouldn't cause issues with code using older Node typings.

See also: theintern/intern#932

Package Version:

2.0.0

Code

Create a project that includes @dojo/shim@2.0.0 and @types/node@10.5.1 and try to build it.

Expected behavior:

It compiles.

Actual behavior:

node_modules/@theintern/leadfoot/node_modules/@dojo/shim/Symbol.d.ts:3:9 - error TS2687: All declarations of 'observable' must have identical modifiers.

3         observable: symbol;
          ~~~~~~~~~~


node_modules/@types/node/index.d.ts:169:14 - error TS2687: All declarations of 'observable' must have identical modifiers.

169     readonly observable: symbol;
                 ~~~~~~~~~~