Maintain parsed aliases for commands over using yargs internal #222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
Parsed aliases are only available from yargs when running a command with a group and name - Therefore running a default command such as
dojo testthrows an error because there is no aliases object.This change moves from using an internally yargs generated and maintained aliases map, to explicitly maintaining an equivalent map in dojo/cli. This means that command line options saved in the dojorc config will work for default commands, aliased commands and regular commands.
Resolves #221