Use @types/yargs
#120
Closed
Use @types/yargs
#120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
=======================================
Coverage 99.45% 99.45%
=======================================
Files 15 15
Lines 369 369
Branches 42 42
=======================================
Hits 367 367
Partials 2 2
Continue to review full report at Codecov.
|
tomdye
reviewed
Mar 8, 2017
| private context: any; | ||
| private configuration: ConfigurationHelper; | ||
| run(group: string, commandName?: string, args?: yargs.Argv): Promise<any> { | ||
| run(group: string, commandName?: string, args?: any): Promise<any> { |
Member
Author
There was a problem hiding this comment.
No because what was Yargs is now Argv and the typing for what was Argv is now any.
Member
Author
There was a problem hiding this comment.
I did mention this in the description.
Member
|
@agubler any reason to not land this after a rebase? |
Member
Author
|
@dylans just the fact that the typings don't seem to be quite as good. Also it's a breaking change as we'd need to convert all the commands. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
Description:
Convert to use @types/yargs.
Discussion as we do lose the typings for
Argvthat seem to be typed asanyin the latest yarg types from @types.Resolves #119