Skip to content

Conversation

@rorticus
Copy link
Contributor

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

Commands can now reject with CommandErrors now instead of regular errors. These are backwards compatible with the current Error objects.

return Promise.reject({
    message: 'Some error message',
    exitCode: 1
});

If exitCode is returned, and not undefined, the process will be exited with that exit code.

Part of dojo/cli-test-intern#7

@codecov-io
Copy link

Codecov Report

Merging #114 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
+ Coverage   99.45%   99.45%   +<.01%     
==========================================
  Files          15       15              
  Lines         364      368       +4     
  Branches       40       42       +2     
==========================================
+ Hits          362      366       +4     
  Partials        2        2
Impacted Files Coverage Δ
src/registerCommands.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59926aa...475216c. Read the comment docs.

@rorticus rorticus merged commit e85912a into dojo:master Feb 27, 2017
@dylans dylans added this to the 2017.02 milestone Feb 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants