Skip to content

Conversation

ndm2
Copy link
Contributor

@ndm2 ndm2 commented Mar 27, 2021

Now to the main show, this adds support for common table expressions and window functions.

I would have liked to add additional nesting on new lines for the FILTER() and OVER() clauses, eg:

GROUP_CONCAT(b, '.')
  FILTER (
    WHERE
      c != 'two'
  )
  OVER (
    ORDER BY
      a
  )
  AS filtered,

however without a larger rewrite of the formatter, all I could come up with was pretty hack-ish, and way too much tied to this specific syntax, so for now it would still be a bit squished.

Resolves #37

@greg0ire greg0ire requested a review from goetas October 11, 2021 21:51
@greg0ire greg0ire requested a review from derrabus November 5, 2021 11:11
@derrabus derrabus added this to the 1.1.2 milestone Nov 5, 2021
@derrabus derrabus added the enhancement New feature or request label Nov 5, 2021
@derrabus derrabus modified the milestones: 1.1.2, 1.1.3 Nov 7, 2021
@greg0ire
Copy link
Member

@derrabus @goetas please review

@derrabus
Copy link
Member

I'm not sure I'm the right person to review code on this repo. 😓

@greg0ire
Copy link
Member

No worries! Let's merge then!

@greg0ire greg0ire merged commit 34fcd2f into doctrine:1.1.x May 23, 2022
@ndm2
Copy link
Contributor Author

ndm2 commented Jun 18, 2022

@greg0ire Any chance that we'll see a new release somewhat soon-ish?

@greg0ire
Copy link
Member

@ndm2
Copy link
Contributor Author

ndm2 commented Jun 18, 2022

Thanks for the swift response, no need to apologize :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for the WINDOW keyword
3 participants