Skip to content

Add extra new line between separate queries #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 6, 2024
Merged

Add extra new line between separate queries #124

merged 2 commits into from
Jun 6, 2024

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Jun 4, 2024

impl. #53, I like it!

@mvorisek mvorisek changed the title Add extra new line between queries Add extra new line between separate queries Jun 4, 2024
@mvorisek mvorisek marked this pull request as ready for review June 4, 2024 11:25
@mvorisek mvorisek marked this pull request as draft June 4, 2024 11:29
@mvorisek mvorisek force-pushed the extra_nl_between_queries branch from 250c05d to 305d8e6 Compare June 4, 2024 11:43
@mvorisek mvorisek marked this pull request as ready for review June 4, 2024 12:01
SenseException
SenseException reviewed Jun 4, 2024
View reviewed changes
@mvorisek mvorisek force-pushed the extra_nl_between_queries branch from fdc69cb to 1f071ce Compare June 4, 2024 22:42
@mvorisek mvorisek requested a review from SenseException June 5, 2024 05:45
@mvorisek mvorisek force-pushed the extra_nl_between_queries branch from 1f071ce to c0254f2 Compare June 5, 2024 07:34
@greg0ire
Copy link
Member

greg0ire commented Jun 5, 2024

I think there should be a test showing that this avoids the ; CREATE TABLE weirdness from the referenced issue.

@mvorisek
Copy link
Contributor Author

mvorisek commented Jun 5, 2024

I think there should be a test showing that this avoids the ; CREATE TABLE weirdness from the referenced issue.

We already test there is new line after ;, especially after #110 fix which imply such testing already - is this reply enough?

@greg0ire
Copy link
Member

greg0ire commented Jun 5, 2024 •
edited
Loading

So, #110 already fixes (the most important) part of #53, is that it?

@mvorisek
Copy link
Contributor Author

mvorisek commented Jun 5, 2024

So, #110 already fixes (the most important) part of #53, is that it?

Yes - #53 is no longer a bug, it is a feature request to add 2 new lines (1 empty) between two queries. This is what this feature does.

greg0ire
greg0ire approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not…

@greg0ire greg0ire added this to the 1.5.0 milestone Jun 6, 2024
@greg0ire greg0ire added the enhancement New feature or request label Jun 6, 2024
@greg0ire greg0ire merged commit 96f20a5 into doctrine:1.5.x Jun 6, 2024
@mvorisek mvorisek deleted the extra_nl_between_queries branch June 6, 2024 08:11
@mvorisek mvorisek mentioned this pull request Jun 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@SenseException SenseException SenseException approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mvorisek @greg0ire @SenseException