Skip to content

Lint Dockerfile files with Hadolint #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2023
Merged

Lint Dockerfile files with Hadolint #316

merged 1 commit into from
Apr 25, 2023

Conversation

phansys
Copy link
Contributor

@phansys phansys commented Apr 24, 2023

No description provided.

@phansys phansys marked this pull request as ready for review April 24, 2023 00:41
@greg0ire
Copy link
Member

Since the plan is to release 12.0.0 as soon as #314 is merged (we need 3 approvals per PR for this repo), I think your new PRs should target 12.0.x so that we don't have to do another merge up.

@phansys phansys changed the base branch from 11.1.x to 12.0.x April 24, 2023 09:31
@phansys phansys requested a review from a team as a code owner April 24, 2023 09:31
ostrolucky
ostrolucky previously approved these changes Apr 24, 2023
View reviewed changes
@phansys
Copy link
Contributor Author

phansys commented Apr 24, 2023

Since the plan is to release 12.0.0 as soon as #314 is merged (we need 3 approvals per PR for this repo), I think your new PRs should target 12.0.x so that we don't have to do another merge up.

I've retargeted all my PRs to 12.0.x. Thank you!

@greg0ire greg0ire added this to the 12.0.1 milestone Apr 24, 2023
@greg0ire greg0ire added the CI label Apr 24, 2023
greg0ire
greg0ire reviewed Apr 24, 2023
View reviewed changes
@phansys phansys force-pushed the hadolint branch 2 times, most recently from 43847f0 to e08b9a9 Compare April 24, 2023 18:20
greg0ire
greg0ire reviewed Apr 24, 2023
View reviewed changes
@phansys phansys requested a review from greg0ire April 24, 2023 18:31
ostrolucky
ostrolucky approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@ostrolucky ostrolucky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of last 7 PRs that I was asked to review, only one was changing the actual coding standard rules. I don't see why we need so many approvals for CI plumbing PRs. There should be something done about this extra noise, otherwise I will disengage and leave @teams/coding-standard-approvers

@greg0ire
Copy link
Member

greg0ire commented Apr 24, 2023 •
edited
Loading

🤔 it is indeed weird that this kicked in:

coding-standard/.github/CODEOWNERS

Line 1 in db39894

/lib/Doctrine/ruleset.xml @doctrine/coding-standard-approvers

@greg0ire greg0ire merged commit 99b196d into doctrine:12.0.x Apr 25, 2023
@phansys phansys deleted the hadolint branch April 25, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ostrolucky ostrolucky ostrolucky approved these changes

@greg0ire greg0ire greg0ire approved these changes

@SenseException SenseException SenseException approved these changes

Assignees
No one assigned
Labels
CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@phansys @greg0ire @ostrolucky @SenseException