Skip to content

GH Actions: update ubuntu images used #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Jan 5, 2023

@jrfnl
Copy link
Contributor Author

jrfnl commented Jan 5, 2023

P.S.: using ubuntu-latest would make this more stable, but I presumed it was fixed on a specific ubuntu version for a reason ?

@greg0ire
Copy link
Member

greg0ire commented Jan 5, 2023

How would it be more stable if it can effectively change from a major version to another? 🤔

@greg0ire greg0ire requested a review from a team January 5, 2023 14:10
@jrfnl
Copy link
Contributor Author

jrfnl commented Jan 5, 2023

How would it be more stable if it can effectively change from a major version to another? 🤔

Well, nothing in this repo actually depends on the Ubuntu version, so the Ubuntu version changing will not have any effect whatsoever. Changing it to ubuntu-latest will prevent random failures like the one I encountered today.

@greg0ire
Copy link
Member

greg0ire commented Jan 5, 2023

It might be a decision we've taken for a repo where it mattered, then copy-pasted everywhere without challenging it.

@ostrolucky
Copy link
Member

I never liked hardcoding ubuntu version in these either. I knew what @greg0ire was going for, but I also knew GH will not want to keep around these old versions forever. Actually I also don't like hardcoding all kinds of other stuff like PHP and Symfony versions, because it has to be maintained and changed all the time. Would be great if there was a way to specify that matrix used is automatically all maintained PHP/Symfony minor versions. But that's off topic, just wanted to rant.

@greg0ire greg0ire merged commit fade017 into doctrine:11.0.x Jan 5, 2023
@greg0ire greg0ire added this to the 11.0.1 milestone Jan 5, 2023
@greg0ire greg0ire added the CI label Jan 5, 2023
@greg0ire
Copy link
Member

greg0ire commented Jan 5, 2023

Thanks @jrfnl !

@jrfnl jrfnl deleted the feature/ghactions-update-ubuntu branch January 6, 2023 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants