Skip to content

Remove SimpleAnnotationReader #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
derrabus merged 1 commit into from
Dec 19, 2022
+1 −263
Merged

Remove SimpleAnnotationReader #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions UPGRADE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Upgrade from 1.0.x to 2.0.x

- `SimpleAnnotationReader` has been removed.
- `DocLexer::peek()` and `DocLexer::glimpse` now return
`Doctrine\Common\Lexer\Token` objects. When using `doctrine/lexer` 2, these
implement `ArrayAccess` as a way for you to still be able to treat them as
Expand Down
112 changes: 0 additions & 112 deletions lib/Doctrine/Common/Annotations/SimpleAnnotationReader.php
View file
Open in desktop

This file was deleted.

140 changes: 0 additions & 140 deletions tests/Doctrine/Tests/Common/Annotations/SimpleAnnotationReaderTest.php
View file
Open in desktop

This file was deleted.

11 changes: 0 additions & 11 deletions tests/Doctrine/Tests/Common/Annotations/Ticket/DCOM58Test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

use Doctrine\Common\Annotations\AnnotationReader;
use Doctrine\Common\Annotations\DocParser;
use Doctrine\Common\Annotations\SimpleAnnotationReader;
use PHPUnit\Framework\TestCase;
use ReflectionClass;

Expand Down Expand Up @@ -78,16 +77,6 @@ public function testIssueWithNamespacesOrImports(): void
self::assertCount(1, $annots);
self::assertInstanceOf(\Entity::class, $annots[0]);
}

public function testIssueSimpleAnnotationReader(): void
{
$reader = new SimpleAnnotationReader();
$reader->addNamespace('Doctrine\Tests\Common\Annotations\Ticket\Doctrine\ORM\Mapping');
$annots = $reader->getClassAnnotations(new ReflectionClass(__NAMESPACE__ . '\MappedClass'));

self::assertCount(1, $annots);
self::assertInstanceOf(Doctrine\ORM\Mapping\Entity::class, $annots[0]);
}
}

/**
Expand Down