Convert ini_get result to bool before evaluating #446
Merged
+9
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LEAN will return true for ["1", "true", "on" and "yes"] and false for ["0", "false", "off" and "no"]
derrabus
approved these changes
Sep 5, 2024
derrabus
added a commit
to derrabus/annotations
that referenced
this pull request
Sep 5, 2024
* 1.14.x: Bump CI actions (doctrine#497) Fix CS Convert ini_get result to bool before evaluating (doctrine#446)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ini_get returns a string, so checking === 0 won't work.
Convert ini_get result to bool before evaluating.
FILTER_VALIDATE_BOOLEAN will return true for ["1", "true", "on" and "yes"] and false for ["0", "false", "off" and "no"]