Skip to content

fix: title error when sidebar link exists with html tag #1404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 22, 2020
Merged

fix: title error when sidebar link exists with html tag #1404

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8aeaf89
fix: title error when sidebar link exists with image
sy-records Oct 20, 2020
791f1b6
fix #1408
sy-records Oct 26, 2020
9810960
add test
sy-records Oct 26, 2020
dbbe271
Merge branch 'develop' into fix-sidebar
sy-records Nov 6, 2020
0cd9ada
Merge branch 'develop' into fix-sidebar
sy-records Nov 9, 2020
580a9bd
Merge branch 'develop' into fix-sidebar
sy-records Nov 18, 2020
6385b7f
Update
sy-records Nov 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/core/render/tpl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,10 @@ export function tree(toc, tpl = '<ul class="app-sub-sidebar">{inner}</ul>') {
}

let innerHTML = '';
let title = '';
toc.forEach(node => {
innerHTML += `<li><a class="section-link" href="${node.slug}" title="${node.title}">${node.title}</a></li>`;
title = node.title.replace(/(<\/?img.*?>)/g, '');
innerHTML += `<li><a class="section-link" href="${node.slug}" title="${title}">${node.title}</a></li>`;
if (node.children) {
innerHTML += tree(node.children, tpl);
}
Expand Down