Merged
Conversation
3 tasks
crazy-max
requested changes
Aug 6, 2025
Member
crazy-max
left a comment
crazy-max
left a comment
There was a problem hiding this comment.
Thanks for your contrib!
See my comments and also you forgot to run docker buildx bake pre-checkin: https://github.com/docker/setup-docker-action/blob/master/.github/CONTRIBUTING.md#submitting-a-pull-request
When addressed please squash your commits.
yarn.lock
Outdated
Comment on lines
1
to
2
| # THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. | ||
| # yarn lockfile v1 |
Member
There was a problem hiding this comment.
Seems a tool on your machine updated the yarn lock, please remove these changes.
src/main.ts
Outdated
| async () => { | ||
| const input: context.Inputs = context.getInputs(); | ||
| const runDir = path.join(os.homedir(), `setup-docker-action-${crypto.randomUUID().slice(0, 8)}`); | ||
| const runDir = input.runtimeBasedir || path.join(os.homedir(), `setup-docker-action-${crypto.randomUUID().slice(0, 8)}`); |
Member
There was a problem hiding this comment.
Need to keep random dir for multiple setup: #141 (comment)
Suggested change
| const runDir = input.runtimeBasedir || path.join(os.homedir(), `setup-docker-action-${crypto.randomUUID().slice(0, 8)}`); | |
| const runBasedir = input.runtimeBasedir || path.join(os.homedir(), `setup-docker-action`); | |
| const runDir = path.join(runBasedir, `run-${crypto.randomUUID().slice(0, 8)}`); |
Contributor
Author
|
sorry let me run bake command and get back. |
Member
Yes and also squash your commits, thanks! |
crazy-max
reviewed
Aug 6, 2025
README.md
Outdated
| | `rootless` | Bool | `false` | Start daemon in rootless mode | | ||
|
|
||
| | `rootless` | Bool | `false` | Start daemon in rootless mode | | ||
| | `runtime-basedir` | String | `false` | Docker runtime base directory |
Member
There was a problem hiding this comment.
Suggested change
| | `runtime-basedir` | String | `false` | Docker runtime base directory | |
| | `runtime-basedir` | String | `<home>/setup-docker-action` | Docker runtime base directory |
ArunKumarT1995
force-pushed
the
feature/rundirinput
branch
2 times, most recently
from
8e15b57 to
e416dff
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
feature/rundirinput
branch
from
e416dff to
28ef634
Compare
crazy-max
approved these changes
Aug 6, 2025
Member
crazy-max
left a comment
crazy-max
left a comment
There was a problem hiding this comment.
LGTM thanks
Pushed extra commit to move default to context
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
feature/rundirinput
branch
from
3105473 to
a4da7e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #141
Adding Input for
runtime-basedirto fixXDG_RUNTIME_DIR needs to be set and writableerror.Updated the docs for the same.