Skip to content

Remove vLLM x86_64 NVIDIA platform warning from pull compat check#794

Merged
ericcurtin merged 1 commit into
mainfrom
rm-vllm-warn
Mar 26, 2026
Merged

Remove vLLM x86_64 NVIDIA platform warning from pull compat check#794
ericcurtin merged 1 commit into
mainfrom
rm-vllm-warn

Conversation

@ericcurtin
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location path="pkg/distribution/distribution/client.go" line_range="798-800" />
<code_context>

 	if config.GetFormat() == "" {
 		log.Warn("Model format field is empty for , unable to verify format compatibility", "model", utils.SanitizeForLog(reference))
-	} else if !slices.Contains(GetSupportedFormats(), config.GetFormat()) {
-		// Write warning but continue with pull
</code_context>
<issue_to_address>
**nitpick (typo):** The warning message has a grammatical issue and is missing the subject after "for".

The log currently reads `"Model format field is empty for , unable to verify format compatibility"`, which suggests a missing interpolated value after `for`. If no identifier is needed here, consider dropping `for` entirely. Otherwise, explicitly include the model identifier (e.g., the `reference` you’re already logging) to make the message clearer.

```suggestion
	if config.GetFormat() == "" {
		log.Warn("Model format field is empty; unable to verify format compatibility", "model", utils.SanitizeForLog(reference))
	}
```
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread pkg/distribution/distribution/client.go
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the logic that checked for and warned about unsupported model formats during the model pulling process. Specifically, it removes the warnUnsupportedFormat constant, the slices import, the platform import, and the associated test cases that verified these warnings. I have no feedback to provide.

Copy link
Copy Markdown
Contributor

@ilopezluna ilopezluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, but I’m unsure about the rationale for removing this warning. Could you share it? 🙏

Comment thread pkg/distribution/distribution/client.go
@ericcurtin
Copy link
Copy Markdown
Contributor Author

@ilopezluna it really doesn't make sense, it appears on macOS even though we delivered vllm support there.

Also, I want people to report vllm doesn't work on my system and see the ugly vllm-log (just like they would see if they tried vanilla vllm). It gives us more feedback on where people are trying to run this.

@ilopezluna
Copy link
Copy Markdown
Contributor

@ilopezluna it really doesn't make sense, it appears on macOS even though we delivered vllm support there.

Also, I want people to report vllm doesn't work on my system and see the ugly vllm-log (just like they would see if they tried vanilla vllm). It gives us more feedback on where people are trying to run this.

makes sense, thanks!

@ericcurtin ericcurtin merged commit e81c289 into main Mar 26, 2026
12 checks passed
@ericcurtin ericcurtin deleted the rm-vllm-warn branch March 26, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants