Skip to content

EDIT: Update python code guide and include linting, formatting and type checking #22737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 24, 2025
Merged

EDIT: Update python code guide and include linting, formatting and type checking #22737

merged 8 commits into from
Jun 24, 2025

Conversation

estebanx64
Copy link
Contributor

@estebanx64 estebanx64 commented Jun 2, 2025 •
edited
Loading

Description

  • I updated the code in the main Python guide. I noticed some deprecations in the libraries. I made a refactor and updated the whole code to be totally up to date with the recent library version
  • I added a section about linting, formatting, and type checking to follow the best practices. I include them in the CI/CD too

@craig-osterhout
@usha-mandya

  • Technical review
  • Editorial review
  • Product review

@netlify Netlify
Copy link

netlify bot commented Jun 2, 2025 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 4113619
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/6859ffeaadad0f000857bb52
😎 Deploy Preview https://deploy-preview-22737--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@estebanx64 estebanx64 marked this pull request as draft June 2, 2025 02:44
@estebanx64 estebanx64 changed the title EDIT: Update python code guide and include linting, formatting and ty… EDIT: Update python code guide and include linting, formatting and type checking Jun 2, 2025
@estebanx64 estebanx64 marked this pull request as ready for review June 2, 2025 02:46
@craig-osterhout craig-osterhout requested a review from a team June 2, 2025 18:31
@craig-osterhout
Copy link
Contributor

Noting that we'll get #22676 merged first before reviewing as it will cause conflicts.

@craig-osterhout
Copy link
Contributor

Hi @estebanx64, thank you for updating this. The PR mentioned above has been merged and is causing a conflict. Please help resolve the conflicts and let me know if you need any help.

@estebanx64
Copy link
Contributor Author

Hi @craig-osterhout, is yours now

craig-osterhout
craig-osterhout requested changes Jun 20, 2025
View reviewed changes
Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this, @estebanx64. It's looking really good. Added a few small style suggestions.

@estebanx64
Copy link
Contributor Author

@craig-osterhout I made your suggested changes. it's ready for you now

craig-osterhout
craig-osterhout approved these changes Jun 24, 2025
View reviewed changes
Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@craig-osterhout craig-osterhout merged commit a30fb9e into docker:main Jun 24, 2025
15 checks passed
@estebanx64 estebanx64 deleted the python-docker-guide-v2 branch June 25, 2025 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igor-alexandrov igor-alexandrov igor-alexandrov approved these changes

@craig-osterhout craig-osterhout craig-osterhout approved these changes

Assignees
No one assigned
Labels
area/guides area/tests status/review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estebanx64 @craig-osterhout @igor-alexandrov