Support for platform in client.images.api.push

[Khushiyant]

API version v1.48 accepts platform argument as parameter to be passed to /images/{name}/push but it is not implemented in image.py.

Below function should accept platform i.e JSON-encoded OCI platform to select the platform-variant to push:

def push(self, repository, tag=None, stream=False, auth_config=None,
             decode=False):

[hoangelos]

@vvoland I see you did the last approval of a PR. Any chance you could look at this? I’m being blocked by this. The SDK supports pulling platform specific docker images. But not pushing them. The ramifications is using the SDK the images don’t retain their tags.

[vvoland]

Sorry for the long wait. I left a comment on the PR. @Khushiyant are you still interested in moving this forward?

[Khushiyant]

Sure, I’ll make the suggested changes. Could you also clarify the general structure you’d recommend for the Platform class?

[vvoland]

It should directly correspond to the OCI Platform:

• Go struct https://github.com/opencontainers/image-spec/blob/64294bd7a2bf2537e1a6a34d687caae70300b0c4/specs-go/v1/descriptor.go#L52-L72
• platform field in https://github.com/opencontainers/image-spec/blob/main/image-index.md#image-index-property-descriptions

[vvoland]

Ideally that would be "dataclass", but it doesn't seem like other struct-like types in docker-py use it, so we should keep it consistent with other types in: https://github.com/docker/docker-py/tree/main/docker/types

[hoangelos]

@Khushiyant how's this coming?

[vvoland]

Sorry, I thought I answered the question on the PR! Just did it now.