Couldn't create secret object

[ddowding]

I couldn't create secret object, the problem seemed to boil down to the way that a secret was being created from the docker daemon response.

docker-py/docker/models/secrets.py

Lines 31 to 33 in 467cacb

	def create(self, **kwargs):
	obj = self.client.api.create_secret(**kwargs)
	return self.prepare_model(obj)

Docker version 18.03.1-ce and python version 3.5 had the following error:

File "docker/models/secrets.py", line 10 in __repr__
return "<%s: %s'>" % (self.__class__.__name__, self.name)
File "docker/models/secrets.py", line 14 in name
return self.attrs['Spec']['Name']
KeyError: 'Spec'

When calling:

import docker

client -docker.from_env()
mySecret = client.secrets.create(name='randomName', data='platform_node_requirements.md')

Changing the code to the following seemed to fix it.

obj = self.client.api.create_secret(**kwargs)
secret = self.client.secrets.get(obj.get('ID'))
return self.prepare_model(secret)

[douglasmiranda]

Master branch is working.

[remorses]

I get the same error for client.configs.create

[etienne-napoleone]

docker version: 19.03.5 633a0ea
docker-py version: 4.1.0

On my side the creation works but the __repr__ method seem to expect a name where the returned object only contains the id attr. Not too bad but it could be handled more gracefully. For example you will get an ugly exception every time you create a secret from an interactive python shell without assigning the returned value.

>>> import docker
>>> d = docker.from_env()

>>> s = d.secrets.create(name="test", data="ok")
>>> s
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/user/Library/Caches/pypoetry/virtualenvs/whatever-py3.7/lib/python3.7/site-packages/docker/models/secrets.py", line 10, in __repr__
    return "<%s: '%s'>" % (self.__class__.__name__, self.name)
  File "/Users/user/Library/Caches/pypoetry/virtualenvs/whatever-py3.7/lib/python3.7/site-packages/docker/models/secrets.py", line 14, in name
    return self.attrs['Spec']['Name']
KeyError: 'Spec'
>>> s.attrs
{'ID': 'wi2jpy7n70wkkrbytnbctv1nj'}

>>> d.secrets.create(name="test2", data="ok")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/user/Library/Caches/pypoetry/virtualenvs/whatever-py3.7/lib/python3.7/site-packages/docker/models/secrets.py", line 10, in __repr__
    return "<%s: '%s'>" % (self.__class__.__name__, self.name)
  File "/Users/user/Library/Caches/pypoetry/virtualenvs/whatever-py3.7/lib/python3.7/site-packages/docker/models/secrets.py", line 14, in name
    return self.attrs['Spec']['Name']
KeyError: 'Spec'

[feliperuhland]

Hi @etienne-napoleone

I opened a PR for that issue. Do you want to review it?
Thanks.