image/list: Add opt-in to --tree by default#5772
Draft
vvoland wants to merge 1 commit intodocker:masterfrom
Draft
image/list: Add opt-in to --tree by default#5772vvoland wants to merge 1 commit intodocker:masterfrom
vvoland wants to merge 1 commit intodocker:masterfrom
Conversation
Add a new `image-tree` feature in `~/.docker/config.json` which will make the `docker image list` use the new tree output by default. The tree output is only used if no conflicting flag is passed (--format, --quiet, --digests, --no-trunc). Signed-off-by: Paweł Gronowski <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5772 +/- ##
==========================================
- Coverage 59.42% 59.18% -0.25%
==========================================
Files 347 353 +6
Lines 29402 29957 +555
==========================================
+ Hits 17472 17729 +257
- Misses 10958 11234 +276
- Partials 972 994 +22 |
Benehiko
approved these changes
Jan 27, 2025
Member
|
Hm, so my thinking with "enable by default" was to make the default a collapsed view of the tree-view, so that the columns stay the same (which is currently confusing, because without docker image ls
IMAGE ID DISK USAGE CONTENT SIZE IN USE
docker-cli-dev:latest 743475d9ae54 817MB 192MB ✔
myimage:latest d4ac66306dd9 16.5MB 7.64MB
docker-dev:latest fb53cf31af0f 2.23GB 580MB ✔
rpmbuild-fedora-41/arm64:latest 347239e5d412 1.53GB 356MB
debbuild-ubuntu-noble/arm64:latest 07141bca479f 1.45GB 360MB
debbuild-debian-bookworm/arm64:latest 1c00b1e78af9 1.74GB 461MB
docker:cli 1624879c3635 260MB 66MB
docker image ls --tree
IMAGE ID DISK USAGE CONTENT SIZE IN USE
docker-cli-dev:latest 743475d9ae54 817MB 192MB ✔
└─ linux/arm64 9431815c64e4 817MB 192MB ✔
myimage:latest d4ac66306dd9 16.5MB 7.64MB
├─ linux/arm64 ec5b4b1cef2d 12.8MB 3.99MB
└─ linux/amd64 2bf9e92542e1 3.65MB 3.65MB
docker-dev:latest fb53cf31af0f 2.23GB 580MB ✔
└─ linux/arm64 12a7c17e1b73 2.23GB 580MB ✔
rpmbuild-fedora-41/arm64:latest 347239e5d412 1.53GB 356MB
└─ linux/arm64 dd5275126098 1.53GB 356MB
debbuild-ubuntu-noble/arm64:latest 07141bca479f 1.45GB 360MB
└─ linux/arm64 032fb99f79b8 1.45GB 360MB
debbuild-debian-bookworm/arm64:latest 1c00b1e78af9 1.74GB 461MB
└─ linux/arm64 2b5c05517def 1.74GB 461MB
docker:cli 1624879c3635 260MB 66MB
├─ linux/amd64 e1b7fa9b2d15 0B 0B
├─ linux/arm/v6 67daf59d1ebd 0B 0B
├─ linux/arm/v7 ed7d82f74a17 0B 0B
└─ linux/arm64/v8 311320051fb1 260MB 66MB |
Member
|
☝️ However, that's where the discussion about these two PRs comes at hand;
|
Collaborator
Author
|
Hmm right, I'll put it as draft for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new
image-treefeature in~/.docker/config.jsonwhich will make thedocker image listuse the new tree output by default.The tree output is only used if no conflicting flag is passed (--format, --quiet, --digests, --no-trunc).
- Description for the changelog