Merged
Conversation
We were being stupid, the main session calls sess.GetMessages, which potentially trims things, either the number of messages if configured that way, or by removing old tool call results. But then we would use GetAllMessages when compacting, resulting in a compaction that doesn't work because the context that we are sending is potentially bigger than the LLMs max tokens limit. Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
Signed-off-by: David Gageot <david.gageot@docker.com>
dgageot
force-pushed
the
fix-compaction-dga
branch
from
4414a84 to
38ba5ea
Compare
rumpl
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of #1520