Skip to content

Add Erlang JIT on arm64 #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Conversation

tianon
Copy link
Member

@tianon tianon commented Jun 22, 2023

This has been supported since 25.x, which we're using on all versions now. 👍

Closes #647

This has been supported since 25.x, which we're using on all versions now. 👍
@tianon
Copy link
Member Author

tianon commented Jun 22, 2023

if test "$ethr_arm_isb_sy_instr_val$ethr_arm_dc_cvau_instr_val$ethr_arm_ic_ivau_instr_val" = "111"; then

This is the bit that makes this slightly risky -- I'm not sure if these instructions are part of the arm64 baseline in Debian/Alpine or not, or whether they're generally common enough that this will be safe?

@tianon
Copy link
Member Author

tianon commented Jun 22, 2023

FWIW, it seems to be fine on the recent AWS Graviton instance I just test built this on 😅

@michaelklishin
Copy link
Collaborator

Can't wait to see this ship!

@tianon
Copy link
Member Author

tianon commented Jun 27, 2023

Yeah, I guess we should just go for it and see what happens. 😅

@yosifkit
Copy link
Member

DC, IC, and ISB all seem to be part of the regular arm64v8 instruction set (A64): https://developer.arm.com/documentation/100076/0100/A64-Instruction-Set-Reference/A64-General-Instructions?lang=en

So, this seems safe to me. LGTM

@yosifkit yosifkit merged commit 98c8f74 into docker-library:master Jun 27, 2023
@yosifkit yosifkit deleted the jit-arm64 branch June 27, 2023 22:23
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Jun 27, 2023
Changes:

- docker-library/rabbitmq@98c8f74: Merge pull request docker-library/rabbitmq#648 from infosiftr/jit-arm64
- docker-library/rabbitmq@188a5d8: Update 3.12 to 3.12.1
- docker-library/rabbitmq@79cf580: Update 3.11 to 3.11.19
- docker-library/rabbitmq@875d1e0: Add Erlang JIT on arm64
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Jun 29, 2023
Changes:

- docker-library/rabbitmq@a3aac33: Update 3.11 to otp 25.3.2.3
- docker-library/rabbitmq@8e703bc: Update 3.10 to otp 25.3.2.3
- docker-library/rabbitmq@98c8f74: Merge pull request docker-library/rabbitmq#648 from infosiftr/jit-arm64
- docker-library/rabbitmq@188a5d8: Update 3.12 to 3.12.1
- docker-library/rabbitmq@79cf580: Update 3.11 to 3.11.19
- docker-library/rabbitmq@875d1e0: Add Erlang JIT on arm64
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Jun 29, 2023
Changes:

- docker-library/rabbitmq@0e653fb: Update 3.9 to otp 25.3.2.3
- docker-library/rabbitmq@faaae42: Update 3.12 to otp 25.3.2.3
- docker-library/rabbitmq@3992197: Merge pull request docker-library/rabbitmq#655 from infosiftr/rpath-fixes
- docker-library/rabbitmq@a3aac33: Update 3.11 to otp 25.3.2.3
- docker-library/rabbitmq@8e703bc: Update 3.10 to otp 25.3.2.3
- docker-library/rabbitmq@87380c1: Ensure that custom openssl is where rpath is configured on all arches
- docker-library/rabbitmq@98c8f74: Merge pull request docker-library/rabbitmq#648 from infosiftr/jit-arm64
- docker-library/rabbitmq@188a5d8: Update 3.12 to 3.12.1
- docker-library/rabbitmq@79cf580: Update 3.11 to 3.11.19
- docker-library/rabbitmq@875d1e0: Add Erlang JIT on arm64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable JIT in Erlang build stage for ARM64
3 participants