Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Add live restore to Info struct#277

Closed
aboch wants to merge 1 commit intodocker-archive-public:masterfrom
aboch:lr
Closed

Add live restore to Info struct#277
aboch wants to merge 1 commit intodocker-archive-public:masterfrom
aboch:lr

Conversation

@aboch
Copy link
Copy Markdown

@aboch aboch commented Jun 14, 2016

This allows some validation during swarm init (see moby/moby#23524 for details) and would allow the --live-restore option to be shown in the docker info o/p.

Signed-off-by: Alessandro Boch aboch@docker.com

Signed-off-by: Alessandro Boch <aboch@docker.com>
@mavenugo
Copy link
Copy Markdown
Contributor

LGTM

@icecrime
Copy link
Copy Markdown

Thanks @aboch. I don't think the field needs to be in a public API for the daemon to take a decision accordingly. Can you please let me know if we don't have any other choice?

So far, not LGTM from my point of view.

@aboch
Copy link
Copy Markdown
Author

aboch commented Jun 14, 2016

@icecrime Current compatibility validation for the swarm command is being done in the cluster pkg as a cluster method. Wanted to keep the validation in the same place. I am not sure of another smple option. Will check.

@icecrime
Copy link
Copy Markdown

I'm thinking that:

  • executor.Backend could have an additional fun IsSwarmCompatible() bool function
  • The daemon can look into its internals (--cluster-store, --live-restore, or anything else really) to reply accordingly.

@aboch
Copy link
Copy Markdown
Author

aboch commented Jun 14, 2016

Thanks for the suggestion @icecrime . Let me see if I can get it working.

@aboch
Copy link
Copy Markdown
Author

aboch commented Jun 14, 2016

Thanks @icecrime I made the change and verified it works.
See https://github.com/docker/docker/pull/23524/files#diff-9cb7240401da846ac7c2252759538e9aR168

I think this PR can be closed, and new method addition review can happen in the docker/docker PR.

@icecrime
Copy link
Copy Markdown

Nice! Thanks

@icecrime icecrime closed this Jun 14, 2016
@aboch aboch deleted the lr branch June 15, 2016 18:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants