Add live restore to Info struct#277
Add live restore to Info struct#277aboch wants to merge 1 commit intodocker-archive-public:masterfrom aboch:lr
Conversation
Signed-off-by: Alessandro Boch <aboch@docker.com>
|
LGTM |
|
Thanks @aboch. I don't think the field needs to be in a public API for the daemon to take a decision accordingly. Can you please let me know if we don't have any other choice? So far, not LGTM from my point of view. |
|
@icecrime Current compatibility validation for the swarm command is being done in the |
|
I'm thinking that:
|
|
Thanks for the suggestion @icecrime . Let me see if I can get it working. |
|
Thanks @icecrime I made the change and verified it works. I think this PR can be closed, and new method addition review can happen in the docker/docker PR. |
|
Nice! Thanks |
This allows some validation during swarm init (see moby/moby#23524 for details) and would allow the --live-restore option to be shown in the
docker infoo/p.Signed-off-by: Alessandro Boch aboch@docker.com