Adding global alias config fields in endpointsettings#22
Adding global alias config fields in endpointsettings#22icecrime merged 1 commit intodocker-archive-public:masterfrom
Conversation
types/container/host_config.go
Outdated
There was a problem hiding this comment.
I wonder if we should make this name more specific to the type of aliases?
HostnameAliases maybe ?
Or if the correct term is Endpoint in this context maybe EndpointAliases ?
There was a problem hiding this comment.
Actually. I reviewed what has been done in moby/moby#19001 and I think that make sense.
If we go with the NetworkingConfig approach, then we can remove this field from HostConfig.
Since the Aliases is carried in EndpointSettings already.
|
LGTM |
mavenugo
changed the title
|
@mavenugo I think you can push a PR on docker/docker with temporary vendoring your change, just so we have time to review it, wdyt ? 👼 |
|
@vdemeester @calavera am waiting on moby/moby#19198 to be merged before pushing the docker side changes for the alias functionality as discussed. |
|
LGTM |
|
needs rebase, sorry |
Signed-off-by: Madhu Venugopal <madhu@docker.com>
|
@calavera thanks. rebased now. |
|
ping @calavera tests are green 👍 |
Adding global alias config fields in endpointsettings
6 participants
@calavera @tiborvass as discussed, this brings in the fields required to support global alias.
The e2e functionality including integration with docker and libnetwork is currently here :
https://github.com/mavenugo/docker/commits/alias_3
Once this PR is merged, I will push the subsequent PR in docker/docker for any discussion.
cc @dnephin
Signed-off-by: Madhu Venugopal madhu@docker.com