Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Adding link (local alias) config in endpointsettings#20

Merged
calavera merged 1 commit intodocker-archive-public:masterfrom
mavenugo:alias
Jan 9, 2016
Merged

Adding link (local alias) config in endpointsettings#20
calavera merged 1 commit intodocker-archive-public:masterfrom
mavenugo:alias

Conversation

@mavenugo
Copy link
Copy Markdown
Contributor

@mavenugo mavenugo commented Jan 8, 2016

Adding the alias fields in engine-api for the upcoming local alias feature (via link)

Signed-off-by: Madhu Venugopal madhu@docker.com

Signed-off-by: Madhu Venugopal <madhu@docker.com>
@mavenugo mavenugo changed the title Adding local and global alias config fields in endpointsettings Adding link (local alias) config in endpointsettings Jan 8, 2016
@mavenugo
Copy link
Copy Markdown
Contributor Author

mavenugo commented Jan 8, 2016

@calavera I decided to split the PR between local and global alias in engine-api to reflect the reality as discussed in the maintainers meeting.

@calavera
Copy link
Copy Markdown
Contributor

calavera commented Jan 8, 2016

LGTM

@mavenugo
Copy link
Copy Markdown
Contributor Author

mavenugo commented Jan 9, 2016

@calavera am waiting on moby/moby#19198 to be merged before pushing the docker side changes for the alias functionality as discussed. I hope we can get this in soon so that we can avoid temporary vendor-in changes.

@icecrime
Copy link
Copy Markdown

icecrime commented Jan 9, 2016

LGTM

calavera added a commit that referenced this pull request Jan 9, 2016
Adding link (local alias) config in endpointsettings
@calavera calavera merged commit ad58689 into docker-archive-public:master Jan 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants