Skip to content

Linter and compiler cleanups and v8 RC5 #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
NelsonVides merged 3 commits into from
Jul 28, 2025
Merged

Linter and compiler cleanups and v8 RC5 #269

NelsonVides merged 3 commits into from
Jul 28, 2025

Conversation

@NelsonVides
Copy link
Contributor

@NelsonVides NelsonVides commented Jul 28, 2025

As in the title, it's a small PR.

@NelsonVides NelsonVides requested a review from gustawlippa July 28, 2025 12:10
@NelsonVides NelsonVides self-assigned this Jul 28, 2025
@NelsonVides NelsonVides added the enhancement New feature, enhancement or code changes, not related to defects label Jul 28, 2025
@coveralls
Copy link

coveralls commented Jul 28, 2025

Pull Request Test Coverage Report for Build 16568645807

Details

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 84.59%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pipes/erldns_axfr.erl 0 4 0.0%
Totals Coverage Status
Change from base Build 16468490480: 0.06%
Covered Lines: 1290
Relevant Lines: 1525
💛 - Coveralls

gustawlippa
gustawlippa approved these changes Jul 28, 2025
View reviewed changes
Copy link
Contributor

@gustawlippa gustawlippa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 👍

@NelsonVides NelsonVides merged commit 81c7238 into main Jul 28, 2025
5 checks passed
@NelsonVides NelsonVides deleted the cleanups branch July 28, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gustawlippa gustawlippa gustawlippa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NelsonVides NelsonVides

Labels

enhancement New feature, enhancement or code changes, not related to defects

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NelsonVides @coveralls @gustawlippa